-
Notifications
You must be signed in to change notification settings - Fork 61
Isolate demos folder
#784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate demos folder
#784
Conversation
|
LucDeCaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, fixed the misversioned packages
|
Happy with the changes. |
stevensJourney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see a lot of hard work has gone into this. This is already a large improvement from the previous setup.
I added some comments for some potential improvements to make it potentially even better.
demos/react-native-supabase-group-chat/src/providers/AuthProvider.tsx
Outdated
Show resolved
Hide resolved
stevensJourney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very happy with these changes. This is going to make life much more enjoyable for everyone :D
Currently, the demos in the
demosfolder use pnpm's workspace feature to link to workspace packages. This is convenient for testing changes to workspace packages, as demos will automatically use the local version - however, it causes issues for other users of the demos, as they are required to install all demos and all packages' dependencies in order to run even a single demo. Also, copying demos out of the monorepo requires one to figure out the correct package versions manually.This PR replaces the
@powersync/*package versions fromworkspace:*to the latest published releases and adds apnpm-workspace.yamlfile to each demo. This isolates the demos from the rest of the workspace and ensures that each demo can run independently from thepowersync-jsrepo's context. For convenience, this PR also adds a set of scripts for re-linking the@powersync/*packages to the workspace (for ease of development and testing) and for upgrading@powersync/*package versions across demos.Importantly, this PR also includes a partial rewrite of the
react-native-supabase-group-chatdemo, which was using old packages and failing to build on my system. The PR which made these changes was merged into this branch, since it also used published PowerSync package versions instead of workspace versions.